Enforce one admission notification per request - #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
notify-admittedoperator commandWhy
One admission cycle could produce both a pending-request alert and a later admitted-epoch reconciliation alert. The two generations had different IDs, so generation-local idempotency correctly accepted both. Token refreshes and multi-client subscriptions also needed stronger cross-lifecycle bounds.
Player impact
An opted-in player can now receive at most one logical Farcaster notification for a given access request. It contains no realm name, FID, username, other-player event, token, or private state. A genuinely new request timestamp after a reviewed reset is the only reset boundary.
Validation
No production notification or database mutation was used for validation.